Product preview card component

Community feedback

• 

  IryDev•1,580

  @IryDevPosted over 1 year ago

  Hi @md-abid-hussain 😄. Congratulation on successfully completing this challenge on the platform ! !

  I have some recommendations in order to improve your solution.

  HTML :

  • Replace the <div class="attribution>by the semantic <footer> tag
  • The footer tag contain informations about author, copyright etc

  I also make pull requests on your Github repo to add this property so you can merge it if the changes suit you

  I hope you'll find this helpful! 😄 Above all, the solution your is really good!

  Marked as helpful

  1
• 

  Md Abid Hussain•400

  @md-abid-hussainPosted over 1 year ago

  Thanks for reviewing and contributing to the code. I will follow this rule from next time as it make more sense semantically.

  0