Skip to content
Submitted 6 months ago

Product preview card component

adonesguerreiro•50
@adonesguerreiro
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I feel like I'm improving the CSS, and I'm improving the responsive part more.

What challenges did you encounter, and how did you overcome them?

Replacing the desktop image with the mobile image was quite challenging.

What specific areas of your project would you like help with?

Responsive layout and HTML.

Community feedback

  • CaveCodes•70
    @CaveCodesPosted 6 months ago
    1. your product title text font weight is a bit too heavy.
    2. your line-height spacing in the paragraph is a bit too much.
    3. reflect these tips https://fedmentor.dev/posts/html-plan-product-preview/
    4. better to add google fonts to HTML not css.
    5. do a modern css reset.
    6. add the font colors etc using css variables. for example:

    /* GLOBAL STYLES */ :root { --primary-color-1: hsl(158, 36%, 37%); --primary-color-2: hsl(30, 38%, 92%);

    --neutral-color-1: hsl(212, 21%, 14%); --neutral-color-2: hsl(228, 12%, 48%); --neutral-color-3: hsl(0, 0%, 100%);

    --fs-paragraph: 0.5rem;

    --fw-500: 500; --fw-700: 700; --font-family-1: Montserrat; --font-family-2: Fraunces; }

    and then in css use this format:

    font-weight: var(--fw-700);"

    1. add padding to body or margin to main to make some space on the edges.

    2. use rem not pixels for width and height and on most things...pixels are not very scalable.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord