CaveCodes• 70
@CaveCodes
Posted
- your product title text font weight is a bit too heavy.
- your line-height spacing in the paragraph is a bit too much.
- reflect these tips https://fedmentor.dev/posts/html-plan-product-preview/
- better to add google fonts to HTML not css.
- do a modern css reset.
- add the font colors etc using css variables. for example:
/* GLOBAL STYLES */ :root { --primary-color-1: hsl(158, 36%, 37%); --primary-color-2: hsl(30, 38%, 92%);
--neutral-color-1: hsl(212, 21%, 14%); --neutral-color-2: hsl(228, 12%, 48%); --neutral-color-3: hsl(0, 0%, 100%);
--fs-paragraph: 0.5rem;
--fw-500: 500; --fw-700: 700; --font-family-1: Montserrat; --font-family-2: Fraunces; }
and then in css use this format:
font-weight: var(--fw-700);"
-
add padding to body or margin to main to make some space on the edges.
-
use rem not pixels for width and height and on most things...pixels are not very scalable.
Marked as helpful
0
