Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

product-preview-card-component-mainHTML CSS

@Cookiemonsterhxc

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Tux3er 780

@Tux3er-Isma

Posted

Hi Cookiemonsterhxc

I reviewed your code and there are some tips to improve your programmer skills:

If you want that the main goes center with flexbox use min-height: 100vh in the body:

min-height: 100vh;

That will make the main element will be perfectly center.

Also when you are making README.md files in github customize it so this will make your Github profile popular.

I recomend you to use variables in css:

:root{ my-font: 'My-font', sans-serif }

so you can acces to this variables like this:

.my-text{ font-family: var(my-font) }

You can use BEM CSS too:

Do not use .container .text

Use .container__text

That make CSS code better

Bye and remeber continue coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord