Design comparison
Solution retrospective
Hi, I'm looking for constructive feedback for this project.
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Fay, you really did a great job, your design is closer to the preview. You made it really awesome, but when I was checking your responsiveness then I found 2 problems.
- As I move to bigger screen then your design instead be at center place, it stick with left handside space. I found the reason behind it.
.container-box { height: 640px; width: 1275px; position: relative; left: 165px; top: 130px; }
in your above css rule you haven't added
margin: auto;
please add it to make sure you design also impress 4K lover people.- Now the next issue that i am going to tell you totally different, you made it responsive but you forget to response for 1366px. How ? From > 768px and <= 1366px screen, your design only capture 60% of screen -width and it looking to bad.
I hope you understand above issues and in order to make Good user experience, you definitely fix above mentioned issue.
Good Luck
Marked as helpful1@nottohavePosted almost 3 years ago@skyv26 Hi Aakash, if I change margin: auto in my css rule in *{}, everything will be out of place and everything has to be rebuilt. It is definitely not a quick-fix. I do not find it to be very important because the provided design file do not specify design has to be in the center, so I don't think I would be going further.
For the issue of how things look in screen size between 768px and 1400px, my simple way to solve this problem is to move the cover image on the back to the right at screen size 1024px for an IPad Pro. I understand the problems you address, but I do not see it as high priority. Thank you for pointing it out anyway! Happy holiday!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord