Ping coming soon page (SASS, Javascript, Font Awesome & BEM)

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, Rael! 👋

  Just wanted to drop in to say nice job on this challenge! 👏 It's a simple one, but I think your solution looks good and the form validation works rather well! 👍

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Rael•270

  @RaelianPosted over 3 years ago

  @ApplePieGiraffe Thank you! ^^

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Rael! 👋

  Well done on this challenge! I really like that you take every feedback you received and implemented it. Your BEM is on point. What I'd suggest is to make more descriptive class names. For example .main__notify isn't really descriptive. If you were to come back to this project after two weeks you wouldn't know what element this class represents. Instead give it name like .main__cta .main__button. It is also applies to main__subscribe. I'd name it .main__text, .main__info or something along these lines.

  Keep up the good work! 💪

  1

  ---

  

  Rael•270

  @RaelianPosted over 3 years ago

  @tediko Thank you, I always wonder if I'm doing the BEM right, especially when I have too many blocks or one big wrapper! And yeah, in regards to the names, I kinda tried to 'branch out' out so to speak with the names... felt like a good idea but I noticed even when modifying in the scss file that I kinda forgot the names for .main__notify and sort of went back for .main__btn in my head. ^^'

  I think I did it to try and make them sound less ambigous and more precise? If that makes any sense but kinda ended up the opposit even when I was working so... yeah, that kinda backfired and just went with it. >.>

  But yeah, I'll stick with more descriptive names from now on. Lesson learned!

  Thanks for pointing it out! ^^

  0