Skip to content
Submitted over 1 year ago

Ping Coming Soon Challenge Solution

Dom dK•20
@domdk
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Ping single column coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This was a challenge. I found myself working on the HTML and CSS first and then the JS. This caused me to have to redo parts of the CSS in order to have the error message fit in the correct place on the page. I was all over the place! For the JS, I used regular expression to do the validation, I have a long way to go with JS, so any help will be appreciated!

Community feedback

  • IryDev•1,580
    @IryDevPosted over 1 year ago

    Hey @domdk, you did a great job on this challenge!

    Your solution is pretty good, all I have to say is to replace the <div class='main'> with the semantic tag <main> that can improve accessibility on your website.

    HTML :

    <body>
<main>
main content of your website
</main>
</body>
    • I propose why don't display a success message when the user gives a valid email address

    I hope you'll find this helpful 😀

    Marked as helpful
    0
    Dom dK•20
    @domdkPosted over 1 year ago

    Thanks for your help, @IryDev! I will give it a try, Cheers!

    0
    IryDev•1,580
    @IryDevPosted over 1 year ago

    @domdk It's a pleasure I didn't do much, your solution is pretty good.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord