Ping Coming Soon

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Yunus Ujjaini! 👋 Good effort on this challenge! Kudos for this animation, I really like when someone playing with this challenges. Take a look at:

  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • Don't use divs everywhere. Your .head element should be a heading <h1-h6> and your .sub-head paragraph <p> or <span>.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Yunus Ujjaini•565

  @yunus-ujjainiPosted over 3 years ago

  @tediko I'll try to use semantic elements as much as possible in my mark-up. Thanks ☺️

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  interesting animation not sure the double vertical scroll bar show up and then goes away

  also it looks like you have two pinterest logos and not the facebook one that should be a quick fix

  1

  ---

  

  Yunus Ujjaini•565

  @yunus-ujjainiPosted over 3 years ago

  @palgramming Yes I know the reason behind the scroll bar issue, will fix it soon (I thought no one will notice 🤭).

  I implemented this solution with mobile first approach and verified by resizing the browser as well. Thanks for that tip... Though doing mobile first was time consuming but once that was done, Transition from mobile to desktop was way more simpler than desktop to mobile.

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @yunus-ujjaini yep it has taken me a while fighting mobile first but once I saw that is was easier to add the CSS to make the desktop than take away from the desktop elements to make mobile I started to understand why people kept saying this method

  1