Design comparison
SolutionDesign
Solution retrospective
It was....hope I did well. all suggestions and feedback are welcome. love and regards
Community feedback
- @ChamuMutezvaPosted over 3 years ago
- there is a
main
semantic element - use it instead of the div with the class of main. Semantic matters
<div class="change"> <p> Change</p> </div>
- the above should have been an interactive element - i would suggest an
a
element - the site is responsive , well done. But i think adding some space at the top so that the image does not touch the top
Marked as helpful1@Vishal-wankhadePosted over 3 years ago@ChamuMutezva will do it next time . thanks for the feedback
0 - there is a
- @dewslysePosted over 3 years ago
Hello Vishal!! I believe you did well on this challenge. Some things to note:
- You should consider wrapping your main content in a
main
tag. You could change<div class="main">
to<main class="main">
.
0 - You should consider wrapping your main content in a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord