Design comparison
Solution retrospective
Hey guys, I have completed this challenge. It took me a lot of time, but finally I have done it. It's not perfect, but yeah, I think I've done it in a complex way. Suggestions and improvements are really welcome, and they will help me a lot!
Community feedback
- @hitmorecodePosted over 1 year ago
Congratulations well done, it's not exactly like the design, but good effort. I've noticed one thing that you really must change
<p1></p1>
and<p2></p2>
these are non existing tags in html. Just use<p></p>
and if you want to distinguish them from each other, give them a class name or id.Another thing I noticed is that you used
<br>
after a p tag. You don't need to use<br>
, because a p tag is already a block element. This means that a p will hold it's own line. Everything that comes after will go to the next lineYou are also not using the correct font-family, you can load them from google. If you don't know what font to use, you can find it in the style-guide.md in the challenge folder.
It's good practice to try to get as close as possible to the original design.
Marked as helpful0@MuhammadZaidKhanPosted over 1 year ago@hitmorecode Thanks alot for the feedback. One thing more how can I remove those spaces between image and container I tried margin and padding but it's not working.
0@hitmorecodePosted over 1 year ago@MuhammadZaidKhan You can create a new div and place img inside the div.
<div class="imag-holder"> <img src="" alt=""> </div>
Give the div a fixed height (don't use %).
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord