Order Summary using flex and grid

Community feedback

• 

  Yehan Nilanga•670

  @Yehan20Posted about 2 years ago

  Hello Congratulations on the on Completing the challenge, I noticed that you have used a position absolute on the footer, which had caused some overlapping with card, I don't think you really need that, since by default the footer is after your main, by removing the position properties and adding some margin top, that can be resolved. Also don't use fixed widths since it will not be helpful when making it responsive. Use a max-width instead of it and see. I hope this was helpful, good luck for other challenges as well.

  Marked as helpful

  1

  ---

  

  Jonatan Trindade•120

  @Jonata-trPosted about 2 years ago

  @Yehan20 A thought about the maximum width for responsiveness, but I had a lot of problems using it. As most of the time the item didn't get the specified size or the max width was just completely ignored and I would just get the size I want using fixed sizes unfortunately

  0

  

  Yehan Nilanga•670

  @Yehan20Posted about 2 years ago

  @Jonata-tr max width is like pretty much same like width in fact when we decrease the viewport size it will decrease automatically, initially giving a max width will not force the element's width to increase, you could add a width 100% in addition with your max width, I hope this was helpful.

  Marked as helpful

  0

  

  Jonatan Trindade•120

  @Jonata-trPosted about 2 years ago

  @Yehan20 It helped me a lot, thanks man. I just haven't figured out how to make it work with images, after some point they stop getting bigger or for some reason don't change size at all.

  0