Design comparison
Solution retrospective
Any feedback will make me much better web programmer :).
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="card"> with the main tag, <h3> with <h2> to fix the accessibility issues. click here for more on web-accessibility and semantic html
There is no need <div class="bg_image"> in the html and its styling in the css. Give the body a background-image with a background-size of contain and a background-repeat of no-repeat. The background-image of the body is pattern-background-desktop.svg
For a responsive content, replace the width in .card with max-width.
max-width: 400px
.In the media query you have to change the background-image of the body.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1@erenymoPosted over 1 year ago@Hassiai Thanks for you direction, I'm gonna take care at all ! ^^
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord