Design comparison
Solution retrospective
All Feedback is Well Come.
Community feedback
- @DavidMorgadePosted about 2 years ago
Hello Achinta, congrats on finishing the challenge!
I would suggest you to set the background pattern as a
brackground-img
in your CSS instead of putting it as an htmlimg
, in this type of cases it fits perfectly to it in your CSS files instead of your html.Also try to use more semantic tags, you could put all of your content inside a
main
tag, instead of just using adiv
, you could also usesection
tag to divide the parts of your card that are semantically related!Hope my feedback helps you for future projects, good job!
Marked as helpful0@FSwebdeveloperPosted about 2 years ago@DavidMorgade thanks you for your advice. This advice really helpful for me.
1 - @dazzlerabhi30800Posted about 2 years ago
Put your whole component inside main tag and use heading levels raised by one only that will take care of the accessibility issues.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord