Order summary component with sass

Community feedback

• 

  Shahin NJ•1,190

  @SJ-NosratPosted over 3 years ago

  Hi, Super solution, pixel perfect (in my opinion)!

  1. The webpage is very responsive. The only suggestions I have with is maybe adding some semantic HTML to your HTML structure. As follows:

  2. Wrap your <img src="./images/illustration-hero.svg" alt=""> element in a <figure> element as this will make your <img> be contained by a landmark.

  3. Also, since <img src="./images/illustration-hero.svg" alt=""> has no alt="" description, then please add the following atrribute: aria-hidden="true", this will allow screenreaders to skip images that are there purely for decorative purposes.

  Looking forward to more of your solutions!

  Best of luck with your coding journey!

  Marked as helpful

  1

  ---

  

  dewslyse•3,025

  @dewslysePosted over 3 years ago

  @shahin1987, thank you very much for the feedback. Really helpful.

  0