Design comparison
SolutionDesign
Solution retrospective
my second attempt at this challenge. I added a background SVG wave.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS π¨:
- Looks like the background
svg
has not been properly positioned. So let me explain, How you can easily apply thebackground color
with thesvg
they provided.
- Add the following style rule to your css, and then experience the changes
body { background: url(/pattern-background-desktop.svg), #E1E9Ff; background-repeat: no-repeat, no-repeat; }
- Tip, Don't forget to generate a new screenshot after editing the
css
file
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @Dharmik48Posted about 3 years ago
Heyπ, Good job with the solution! One thing I say you need to improve on is:
- Start using semantic html tags like,
main
,header
,footer
, etc. It is a very good practice and good for SEO.
Keep Developingππ€.
Marked as helpful1@Tiyana19Posted about 3 years ago@Dharmik48 thanks... I will definitely try to use them in my next project.
0 - Start using semantic html tags like,
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord