Design comparison
SolutionDesign
Solution retrospective
Hi, this is my second challange. I see few problems in my coding:
- it is diffucult for me to get proper size of elements and whole project,
- I am afraid my code isn't efficient, too much lines, I don't know the easiest and the shortest way to do some stylings,
If you have any adivces how can I fix or make better my code please give me some feedback.
Community feedback
- @mk-muzzammilPosted over 1 year ago
Overall you did well try to do some changings. Try to just fix the width using absolute units like px but not height keep your height default and when you have done this now give their children containers max-width 100% not height 100% by this You will better your code for more review my code of order-Summary challenge i hope it helps you alot
0 - @hitmorecodePosted over 1 year ago
It's OK what you did. I would only change two tings
background-repeat: repeat-x;you can replace this withbackground-repeat: no-repeat;- Try to avoid naming classes after tags. You gave a paragraph a class name
h1. Give it a class name to something it can relate to. For example<p class="product__description">
Other than that, well done Keep it UP
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord