Html and Css

Community feedback

• 

  Adriano•38,250

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Dewan Md Shakib al-mujib, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  To prevent the background image from breaking at higher resolutions, we can prevent this in two different ways:

  1. Add a background-repeat: repeat-x;, the image will repeat on the horizontal axis, preventing it from breaking.
  2. Add a background-size: 100% 50vmin;, the 50vmin will set its height as the page target, and 100% will make it stretch on the horizontal axis.

  Feel free to choose one of the two!

  images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.

  The remainder is excellent.

  I hope it's useful. 👍

  Marked as helpful

  0
• 

  Sanjeewa Marukona•200

  @eewa-SANJPosted almost 2 years ago

  Overall your solution is great but there, but you can make some improvement Here are my findings

  1. Missing the box shadow on the "proceed to payment" button
  2. Missing the provided font in the "proceed to payment" button text where different font family is being inherited
  3. Does not change underline in the "change" link when the mouse hover
  4. When you writing CSS, try to format each property according to alphabetical order which is for readability but the only suggestion

  These are,y finding and try to fix them if you can possible.

  Marked as helpful

  0