Design comparison
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Rogerio,
Really nice work and even your design is responsive. I have one suggestion,
As I can see that your background (wavy img) is not covering full width. Just add
background-size: contain;
property in your body tag's CSS.Happy New Year ;)
Marked as helpful1@rogeriobautzPosted almost 3 years ago@skyv26 Thank you for the feedback. I added the background-size property and it looks better.
1@skyv26Posted almost 3 years ago@rogeriobautz Your Welcome.
Best Of Luck For Next Challenge
0 - @anoshaahmedPosted almost 3 years ago
To get rid of the accessibility/HTML issues shown in your Report: use
<a>
as a button and don't use<button>
inside of<a>
Good job! :)
Marked as helpful1@rogeriobautzPosted almost 3 years ago@anoshaahmed Thank you for the feedback. I removed the button tags and styled the anchors tags as buttons. I thought that the button tag was better for acessibility because indicates that it is a button.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord