Design comparison
Solution retrospective
Feedbacks are greatly appreciated!
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Harish, Really nice work, I checked your design and responsiveness to. I have some suggestions for you which I think helpful for you and solve your minor issues too.
-
Your annual plan container padding is more than required, I think it need to reduce to make your card little bit more better.
-
Your mobile response is good, but I see one issue that is your background image is at the top and not covering the required height in order to look more better. I go through your card and I found reason and that's your using desktop background image in mobile response.
-
This challenge images folder does contain different background image for mobile provided by FEM and you need to change the image for mobile view.
-
I saw your error report and also checked your code and I found that you are using section tag as a child of div container and it is not good practice, just replace section tag with only div and your issue will then resolve.
I hope you understand above and soon will fix it.
Good Luck
Marked as helpful1@HarishPRKPosted almost 3 years ago@skyv26 Hi Aakash, those are some valuable suggestions! Thank you very much. I'll make sure to use this so that my build looks better!
1 -
- @anoshaahmedPosted almost 3 years ago
To avoid accessibility issues in the future wrap everything in your body in <main>
Good job! :)
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord