Design comparison
SolutionDesign
Solution retrospective
Any feedback is appreciated!!
Community feedback
- @dewslysePosted about 3 years ago
Hello Alicia 👋! Congrats on completing your first challenge on frontend mentor. Your solution is well implemented. Well done 👏👏👏. Some things to note:
- You could wrap your
img
on line 20 of the html in aheader
orfigure
tag to have it selected by a landmark. For improved accessibility, add and empty alt (alt=" "
) to theimg
tag and setaria-hidden: true
.
Alternatively, your could attach the image to the page in
body
of your css. Eg.:body { background: $pale-blue url("./images/pattern-background-desktop.svg") no-repeat; background-size: contain; }
h
andp
elements cannot be child elements of aspan
. You could replace the<span>
with a<div>
Happy coding and best of luck with subsequent challenges
Marked as helpful0 - You could wrap your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord