Design comparison
SolutionDesign
Solution retrospective
Any improvement is appreciated
Community feedback
- @ChamuMutezvaPosted about 3 years ago
Greetings Nazeer. Some issues have been raised in the report that needs fixing. These issues may include the following:
- the alt values for you images must be descriptive enough to benefit assistive tech users who rely on the alt values to visualize the message that is being put across. Words like
logo, image, icon etc
should not be included in the alt value, they are automatically announced as such by screen readers. Decorative images can be written asalt=""
- one of the errors mentioned can be fixed by having a
main
element. It is important to use semantic elements . - in your
.info__list
in particular, the immediate children of aul
element areli
elements. A div cannot be a direct child of aul
- when using icons in the links as you did in the
social__list
, the link is supposed to have text that can provide the purpose of the link to screen reader users. You can do that by using a span as a child of the anchor element but it should be visible hidden using the sr-only technique or an other styling that makes sure that the content will be available to screen readers
Marked as helpful0 - the alt values for you images must be descriptive enough to benefit assistive tech users who rely on the alt values to visualize the message that is being put across. Words like
- @Dharmik48Posted about 3 years ago
Hey👋, Good Job on completing the challenge! But there are a few things you should improve:
- there's too much space in between some elements, decrease it a bit.
- You have used just too many
div
s , some elements can be moved to the samediv
rather than(have same parent) having a differentdiv
. - You should use semantic html like
section
,main
, etc. It is a very good practice.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord