Design comparison
Solution retrospective
In this challenge, I learned about mobile first workflow which makes the website work faster because it has been handled in advance. In addition, I added a focus selector so that users who use the keyboard can be more comfortable while on the website.
What challenges did you encounter, and how did you overcome them?the challenge is just a habit because I did this challenge from the mobile version first.
What specific areas of your project would you like help with?all areas of html and css
Community feedback
- @TedJenklerPosted 3 months ago
Hi @Fbeye04,
Nice project! Here are a few additional recommendations:
OG Meta Tags: I strongly recommend using OG (Open Graph) meta tags to improve SEO and the shareability of your site. Proper OG tags can significantly impact how your site appears when shared on social media and can make a difference in search engine ranking, potentially even affecting whether your site appears in search results.
ARIA Labels: When semantic HTML elements aren't applicable, make sure to add aria-label attributes to your <div> elements. This practice enhances accessibility and contributes positively to SEO by helping screen readers understand the content and purpose of these elements.
Keep up the great work!
Best, Teodor
Marked as helpful0 - @mkborisPosted 3 months ago
Great work @Fbeye04, some areas for review
- To improve the semantic meaning of these .media-buttons, you should use the
a
(anchor) tag instead of thebutton
tag. Thea
tag is used for navigation to other pages, while thebutton
tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered listul
to group the .media-buttons is a better approach for both semantics and accessibility. - Change the
height
of the body tomin-height
Using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues with content that exceeds this height. - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
Marked as helpful0 - To improve the semantic meaning of these .media-buttons, you should use the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord