One Stop Social Links Profile

Community feedback

• 

  P

  Teodor Jenkler•3,740

  @TedJenklerPosted 2 months ago

  Hi @Fbeye04,

  Nice project! Here are a few additional recommendations:

  OG Meta Tags: I strongly recommend using OG (Open Graph) meta tags to improve SEO and the shareability of your site. Proper OG tags can significantly impact how your site appears when shared on social media and can make a difference in search engine ranking, potentially even affecting whether your site appears in search results.

  ARIA Labels: When semantic HTML elements aren't applicable, make sure to add aria-label attributes to your <div> elements. This practice enhances accessibility and contributes positively to SEO by helping screen readers understand the content and purpose of these elements.

  Keep up the great work!

  Best, Teodor

  Marked as helpful

  0
• 

  Boris•2,870

  @mkborisPosted 2 months ago

  Great work @Fbeye04, some areas for review

  • To improve the semantic meaning of these .media-buttons, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered list ul to group the .media-buttons is a better approach for both semantics and accessibility.
  • Change the height of the body to min-height Using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues with content that exceeds this height.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.

  Marked as helpful

  0

  ---

  

  Fachrezi•200

  @Fbeye04Posted 2 months ago

  @mkboris thanks man, your advice gave me new insight.

  0