Design comparison
SolutionDesign
Solution retrospective
honestly i didn't found anything as difficult in this challenges it was quite an easy one
Community feedback
- @Thewatcher13Posted over 1 year ago
- Add landmark roles in your project
- Your cancel should be a button, not a p tag
- Your change has a p tag and an a tag, that's not good and right html. The p tag is not necessarily bcs the change is a label for the link..
- Dont skip the heading order in html, you can't have an h2 before an h1
0 - @hitmorecodePosted over 1 year ago
The image on the card is not showing, you need to change the url of the image
<img src="/images/illustration-hero.svg" alt="" class="cover">
and<img src="/images/icon-music.svg" alt="">
this is what you have.Change it to this
<img src="images/illustration-hero.svg" alt="" class="cover">
and<img src="images/icon-music.svg" alt="">
body { background-image: url(../images/pattern-background-desktop.svg); background-repeat: no-repeat; background-size: contain; background-color: hsl(225, 100%, 94%); min-height: 100vh; display: flex; justify-content: center; align-items: center; font-family: "Red Hat Display"; }
Make the height of the card smaller, right now there is too much empty space at the bottom of the card.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord