Design comparison
Solution retrospective
Hello, Frontend Mentor Community,
This is my solution for the Second Solution for the Notification Page Main .
Spent the whole night trying to make it function and had to readjust the html class and tags just to access them easy via javascript ! I learnt a lot:
- Animation using keyframes
- Using the index properties
- child selector in javaScript
Feel free to leave any feedback and help me to improve my solution (or) make the code clean! CUSTOM TWEAKS..🚀
I'll be happy to hear any feedback and advice!
you also check out my mentor solutions @0xAbdulKhalid.. Thank you boss
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
JAVASCRIPT 🟡:
- The way you declared variables are need to be well structured and organized
- Take a look at the following example code which describes a better way of declaring variables to have a well structured code
const firstName = "Your"; const lastName = "Name"; const emailAddress = "[email protected]"; const password = "supersecret";
- instead try this,
const firstName = "Your", lastName = "Name", emailAddress = "[email protected]" ••• ••• // n number of declarations password = "supersecret"; // make sure to add a semicolon at end of last declaration
- This single line declaration with separated commas will helps you to have a better structured code and improves readability though
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
PS : Glad to hear that I'm your mentor 😊
Happy coding!
Marked as helpful1@BoyutifePosted over 1 year ago@0xAbdulKhalid I will do that right away. Thanks for taking out time to go through my code
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord