nft-preview-card-component-main

Community feedback

• 

  P

  Miguel•640

  @miguelzagaPosted over 2 years ago

  Great animation! the ::before and ::after for the .card__link is very clever.

  I am not sure about this, but is it a good practice to use the block and the element in css selector? I thought you were only meant to use one. For instances, instead of writing ".card .card__top" you would write ".card__top". What do you think?

  And I was looking at your code, I think you could be a bit more specific with your commit messages.

  And I think you organized very well your html. The class names are short and meaningful. Great stuff.

  Marked as helpful

  1

  ---

  

  Yehan Nilanga•670

  @Yehan20Posted over 2 years ago

  @miguelzaga Thanks for the Advice , I agree on the commit message I didn't think of it a lot , but I will make them meaning full next time I do a challenge, Regarding the Second point I also don't have big idea weather its not good or not , but i just wanted to show that this classes are children of the card class in css that's why I did like this. Thanks again for your Tips .

  0