Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT-Preview-Card-Component

@kabir-afk

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This was my take on the challenge , feel free to drop any suggestion that'd help me grow

Community feedback

Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

  • In order to fix the accessibility issues, you need to replace <div class="container"> with the <main> tag and <div class="attribution"> with the <footer> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

  • Also, each main content needs to start with an h1 element, and also contain only one h1 element. Your accessibility report states the need for one main landmark. So, you need to use a <h1> element in the <main> tag instead of using <h2>. You can replace your <h2>Equilibrium #3429</h2> element with the <h1>Equilibrium #3429</h1> element.

Hope I am helpful. :)

Marked as helpful

0

@kabir-afk

Posted

@ecemgo Well I was not concerned with the attribution much as it is pre-provided...regarding the semantic tags., I'll keep it in mind..Thnx bruv

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord