Skip to content
Submitted almost 3 years ago

NFT preview card component with flex and sass

Joaquin Trivel•240
@jtrivel
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Anton Sukhadolets•330
    @SuhodolecAPosted almost 3 years ago

    Hi! Looks great! Really good work! But one little clarification from my side. I think the interactive elements need to be links(<a></a> tags). It means when you click for the headline or main image or creator name you should move to the article, creator profile, etc.

    Good luck!

    Marked as helpful
    1
    Joaquin Trivel•240
    @jtrivelPosted almost 3 years ago

    @SuhodolecA thank you for your review, you are totally correct somehow I missed that about the elements needed to be links. will fix it asap. thanks again.

    0
  • Aakash Verma•6,710
    @skyv26Posted almost 3 years ago

    To solve accessibility issues:

    1. wrap everything in your body in <main> OR give role="" to the direct children of your <body> ... Click here to read more here

    2. Use only one <h1> in your whole one page code.

    3. Don't let alt attribute empty, always add some meaning text in it, so that user able to understand.

    <img src="src/images/image-equilibrium.jpg" class="card__img">

    Instead do this

    <img src="src/images/image-equilibrium.jpg" class="card__img" alt="NFT equillibrium main image">

    Good Luck ;)

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord