NFT preview card component using HTML, SASS and BEM.
Design comparison
Solution retrospective
I have completed the challenges of Frontend mentor, newbie level using html, sass, javascript and the BEM methodology. It was a lot of fun doing the challenges, now I'm going for the Junior level, I'll use Typescript for that level. I'm trying to write clean HTML and CSS code, so any feedback will be appreciated.
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Esteban, You did awesome job, your design is responsive too. But let me tell you something.
-
Always stick with requirements. As you said you need feedback on your code, so according to requirement you also had to implement image hover state with an eye icon. But you did not implement and that implementation is really good to learn CSS little bit more deeper and also help you in future projects.
-
It is my suggestion that if your card have some border radius then give some border-radius to internal block in order to look more better, like , your equillibrium image haven't border-radius. It is my suggestion, agree or not is your choice.
I hope you understand.
Best of Luck
Marked as helpful0@stebancPosted almost 3 years ago@skyv26 Hi Askash, thanks for the comment and observation. I have already added the missing requirements, I had not noticed thanks.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord