NFT preview card component solution

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container-flex"> element with the proper semantic element <main> in your index.html file like <main class="container-flex"> to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Ashwani Pandey•180

  @ashwanipydevPosted over 1 year ago

  "Thank you for the valuable feedback on our code! Your suggestions have been truly unique and will undoubtedly lead to significant improvements. Grateful for your time and expertise!"@0xAbdulKhalid

  0
• 

  hitmorecode•6,680

  @hitmorecodePosted over 1 year ago

  For the hover effect you can do something like this. You will need to adjust for yourself. This is just an example how you can do. Don't forget to add the eye image.

  You don't need position relative on the body.

  body{
  min-height: 100vh; /* for good practice try using min-height */
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  background-color: var(--Very-dark-blue-main-BG);
  font-size: 18px;
  font-family: var(--ff);
  word-spacing: 1px;
  /*     position: relative; */ /* not needed */
  }
  
  .top_img::before {
  content: "";
  width: 286px;
  height: 286px;
  background-color: rgba(255, 0 , 0, .0);
  position: absolute;
  }
  
  .top_img:hover::before {
  background-color: rgba(255, 0, 0, .5);
  }
  

  Marked as helpful

  0

  ---

  

  Ashwani Pandey•180

  @ashwanipydevPosted over 1 year ago

  I want to express my gratitude for your help, not just for the code but also for making the overall process of taking this journey smoother and enabling enjoyable learning. Thank you for your time and expertise.@hitmorecode

  0