Design comparison
Solution retrospective
I started Frontend developing recently which is why my solution is missing some of the features, any feedback would be appreciated. Thank you.
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Melad, You did your best and I appreciate your efforts. I checked your work and noticed some issues and they are as following:
- Images like etherium icon and user avatar images links are broken they are no more visible. I know they were visible in your laptop/desktop but after deployment on github, images are no more visible.
You have to slighlty change your card and it will then be ok.
SOLUTION
check below code
<img src="/images/image-avatar.png" alt="Avatar"> <img src="/images/icon-ethereum.svg" alt="Ethereum Icon">
replace above with below
<img src="./images/image-avatar.png" alt="Avatar"> <img src="./images/icon-ethereum.svg" alt="Ethereum Icon">
just little change I have just prepend (.) period in your image src path and after commit and push code it will then visible.
READ ARTICLE ---> CLICK HERE FOR BETTER UNDERSTANDING
-
Your hover states are missing and they are most important as per part of this challenge requirements, So please implement that part too.
-
Need some improvement in your code after implementing above.
I hope you understand and will make changes in your code in order to make it look better.
Best Of Luck
Marked as helpful1@meladcodesPosted almost 3 years ago@skyv26 Hi, thank you so much for spending your time to give me feedback. I will try to improve it with the changes you have suggested!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord