NFT Card Challenge

Community feedback

• 

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  Hi! Akash, I checked your work, you did it good. But i noticed some issues in your work and that issues are as following:

  1. As you already wrote in your question box that you didn't able to implement the box shadow work, you just need to replace below line in your .container class. box-shadow: 0 10px 10px 5px rgb(0 0 0 / 32%);

  2. Your hover states are missing in your work and that's really important because they are the part of requirement as given in readme file.

  3. You have not implemented media queries, in order to make it responsive. Keep in mind your challenge's solution responsiveness must needed because everyone use their phone first to open any webpage and website.

  I hope you understand the above issues and I would suggest you to focus on your CSS skills more.

  Good Luck

  Marked as helpful

  1

  ---

  

  Akash Pandya•10

  @akashpandyaPosted almost 3 years ago

  @skyv26 Thanks! I totally forgot about the hover effects you are right! I will learn more Css. Thanks for the reply.

  1
• 

  Saran•460

  @Saran-73Posted almost 3 years ago

  Hi 👋

  • Try this box-shadow:0px 13px 3px 10px rgba(0,0,0,0.1), 0px 26px 5px 18px rgba(28, 38, 53, 0.1);

  • use <main>tag for your container

  • change <h4> to <p> tag, u should use h tags in increasing order.

  Marked as helpful

  1
• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  To avoid accessibility and HTML issues in the future:

  • wrap everything in your body in <main>
  • start your headings with h1 and move up by one level each time

  Good job! :)

  Marked as helpful

  0