Skip to content
Submitted almost 3 years ago

NFT Card Challenge

Daniel•280
@ddaniel27
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi! I haven't done this in a long time, so this is my solution.

Feel free to give me feedback, I'll really appreciate it.

Community feedback

  • Ediongsenyene Joseph I.•1,675
    @IEdiongPosted almost 3 years ago

    Hello @ddaniel27, welcome back. Here are some suggestions;

    • the image seems distorted. Remove the height from it and find another way around the positioning it.
    • wrapping clickable items in <a> tags is very good for accessibility. You could wrap the <img>, <h2> and .creator-text span in an <a> tag.
    • Also, look into the accessibility and HTML issues raised here.

    I hope this was helpful. Shalom!

    Marked as helpful
    0
    Daniel•280
    @ddaniel27Posted almost 3 years ago

    @IEdiong Thanks for your feedback, I'll take it in mind the next time!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord