News letter signup form with BEM notation

Community feedback

• 

  Yulia•400

  @YuliaLantzbergPosted 1 day ago

  Hi Csaba. It's a good solution. However I've noticed a few things that maybe can be improved. First, there is an email on the success page. You need to change this to the one that the user entered. Second, you wrap the label and the placeholder for the error text into div and then you put the error message inside span. As much as I know, <span> tag we need inside other inline elements. So, you could, for example, to put it inside label and to get rid off div. But if you use div yet, then it's better to take a <p> tag. Hope it makes sense. Happy coding :-)

  Marked as helpful

  0

  ---

  

  Csaba Hell•180

  @hellcsabaPosted about 15 hours ago

  @YuliaLantzberg Hi Yulia,

  Thank you for the tips, I'll fix my code based on them. You are right about the email on the success page, somehow I missed that.

  I used the div input-group to be able to use flexbox for the correct appearance and yes the <p> tag can be better in my case than the <span>.

  I really appreciate your feedback.

  Happy coding! :)

  1