Newbie: QR Code Component - Astro JS, Sass/Scss

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you. 🤗

  In order to fix the accessibility issues:

  • You need to replace <div class='container'> with the <main> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Another issue is that your <img> tag should include "alt" = attribute.
  • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you need to use a <h1> element in the <main> tag instead of using <span>. You can replace your <span class='title'>Improve your front-end skills by building projects</span> element with the <h1 class='title'>Improve your front-end skills by building projects</h1> element.

  Hope I am helpful. :)

  Marked as helpful

  1

  ---

  

  Irvan Maulana Ahmad•80

  @vanirvanPosted over 1 year ago

  @ecemgo thank you very much, i have 4 accebility report and 1 HTML validation report, after following your guide, i no longer have those report.

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @vanirvan I'm happy to help! 🤗

  0