Mobile first with Flexbox

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Agnieszka! 👋

  Congrats on finishing another challenge! Your solution responds well. Here's my small suggestions:

  • Add some padding to your .wrapper so your container doesn't stick to borders on mobile resolutions.
  • I would use <ul> unordered list for .card-3__text instead of paragraph.
  • You write wrong BEM. Read more about it. card card-1 tells us that these are two elements instead you should write element + modifier like card card--intro. (more descriptive names also, isntead of 1) Then you use element and modifier at once card-1__heading--primary instead it should be card card--intro-heading-primary etc. Really, take a read about it again. This will result in.

  Good luck with that, have fun coding! 💪

  0

  ---

  

  P

  Axseinga•430

  @axseingaPosted over 3 years ago

  Hi tediko,

  Thank you for taking time again to comment my solution and for your advises :) I will fix my code. I am constantly getting lost with BEM. I read two articles after your comment about it, but still when it comes to practise I am getting lost especially when nesting (it might grow very quickly). Can you please recommend any good source with examples maybe that I can read some more info about it? Thank you!

  0

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @axseinga Not really. I was learning by trial and error too on that. Take a look at this tho, and maybe watch some youtube videos on it? Good luck :)

  0