Design comparison
Solution retrospective
Flex basis saved me for the bottom 4 links because the list item was overflowing if the a tag was too long. What I previously did was set the list item which contained the a tag to just 50% in the flex container but it was still overflowing out the grid layout. And that was the very problem because when the list item was given a fixed width, the flex container had no idea it was taking more than 50%. So instead, I removed the width, and just set the flex basis in which it saw it was more than 50%, so it wrapped thanks to flex-wrap.
Community feedback
- @Dharmik48Posted about 3 years ago
Hey👋,
Great job with the solution! Looks and functions really good! Just a couple of issues:
- You have added a class of
header
to theheader
tag and I think it's unnecessary. As there will only be oneheader
in the page. - Also if possible try to add some
hover
effect withtransition
to the search button, as it will increase the experience.
Keep Developing👍
0 - You have added a class of
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord