Mobile first using Flexbox & Grid, Sass + vanilla JS

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Agnieszka! 👋

  I didn't expect you to finish this fast 😅 Your solution looks very good and also responds well. We've talk about it yesterday but I just want to link you some resources to help you understand BEM better. link1 - en - very straight forward, simple example. link2 - pl - this was my first video I watched about BEM. I think it is very descriptive but I think it is a bit long-winded.

  Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility. Your .wrapper can be a <section> and your .accordion should be a footer element.

  Personally I'd use parapgraph for .heading--secondary text. It is description and doesn't need to be heading. Your h1 heading is enough.

  Thanks for the shoutout in github readme! 😊 Good luck with that, have fun coding! 💪

  0

  ---

  

  P

  Axseinga•430

  @axseingaPosted over 3 years ago

  Hi Tediko!

  I decided to wake up the next day early in the morning because I knew this week is going to be busy for me and might not find time to finish. Actually, it didn't take that long. I thought this one is going to be difficult in terms of writing media queries. When I started this project I worried about how I am going to move the slider on the right position and then I started writing media queries and used grid and it was easy peasy 😅

  Thank you for the links regarding BEM. I just had a chance to watch it and thank you soo much for the link to Samuraj's video. I would not pick it myself for the very same reason (I had to admit I skipped one time!) But I think I finally get what I am doing wrong (nesting elements inside elements) and I think I understand more about modifiers. I will try to write my next project focusing on using this methodology in the right way.

  In those small components, I am usually not bothered by using semantic but it might be a good practice before moving to big ones.

  A shoutout is well deserved! You helped me a lot especially with refactoring my code. It would have look ugly if not for you! Thank you.

  0