Skip to content
Submitted over 3 years ago

Mobile first using BEM and Vanilla CSS

Atharva Shandilya•160
@Atharva-Shandilya
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social proof section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I recently read about BEM and used it in my project. I am still not very confident in it, so if there is a problem in my code or there is way to improve my code please inform me.

Community feedback

  • tediko•6,680
    @tedikoPosted over 3 years ago

    Hello, Atharva Shandilya! 👋

    Congrats on finishing another challenge! Your solution responds well. Here's my few suggestions:

    • You repeat your HTML code with stars images which is unnecessary. Find the way to use only one star image for a .rating__stars. You can do it easily by using background-repeat approach in your css.
    • Change the alt attributes for the testimonial avatars, as they don't any extra context for screen reader users. Changing to alt="" will make screen readers skip those avatar images.

    Good luck with that, have fun coding! 💪

    1
    Atharva Shandilya•160
    @Atharva-ShandilyaPosted over 3 years ago

    Thanks for your feedback :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord