Mobile first testimonials section with grid

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted about 4 years ago

  This looks really nice code Joanna.

  On your grid, remember you can use shorthand for css values like gap: 25px 25px; - no need to have two values if your row and col gap are the same 😊

  And on your testimonial-header, you could make that a header html element if you wanted. Not necessary, but would make sense.

  The only thing I question in your html markup is the h2s. They don't feel like they should be headings to me. If you imagine the whole document content written out in plain text, what would be the heading? I expect it would be the person's name....

  But really these are down to personal choice I think.

  Good job

  1
• 

  Maxence Yrowah•155

  @maxenceyrowahPosted about 4 years ago

  I find your work super impressive Joanna Skrzypczak but I have a little problem when I open the chrome console to test the responsive there is a small bug in the centering

  0

  ---

  

  Joanna Skrzypczak•530

  @joaskrPosted about 4 years ago

  @maxenceyrowah Thanks! I'll fix it :-)

  0

  

  Maxence Yrowah•155

  @maxenceyrowahPosted about 4 years ago

  @joaskr great 👍

  0