Submitted over 3 years ago
Mobile first stats preview card component with HTML and CSS
@Pow3rZ
Design comparison
SolutionDesign
Solution retrospective
Would like some feedback about html structure and css classes etc.
Is it optimal or any room for improvement ?
Community feedback
- @IEdiongPosted over 3 years ago
Nicely done!
On improvements,
- use semantic tags like
<main>
to wrap your main content<footer>
to wrap your.attribution
class - use an
h1
tag for your.card-heading
- generally think of how you'd present the whole page in a word document, considering things like list, paragraphs, heading etc
- take a look at the accessibility issues raised.
I hope this was helpful!
Marked as helpful1@Pow3rZPosted over 3 years ago@IEdiong Wasn't really thinking about it like a whole page just little component that you can copy-paste on real website hence the lack of
<main>
<h1>
and<footer>
.Should treat every little component project like a full page ?
0 - use semantic tags like
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord