Mobile first solution using SCSS and CSS grid

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The article element is not the best choice ❌ for wrapping these testimonials. In order to use the article element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.

  More Info:📚

  MDN Article Element

  • For the testimonials, it is best ✅ to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  MDN Figure Element

  • The headings in your component are being used incorrectly❌. Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has several headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  • The only headings ⚠️ in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph element.

  • The profile images are not decorative ❌. They should NOT have aria-hidden="true" and alt tags need to be improved ⚠️. It should state the person’s full name.

  If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  Happy Coding! 👾

  Marked as helpful

  0

  ---

  

  Imran Khan•370

  @astr0n0merPosted almost 2 years ago

  Hi @vcarames,

  Thanks for taking some time out to review my code. I'll definitely implement the corrections you have suggested.

  Thanks again😀😁.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @astr0n0mer

  Glad I could help!

  0