Mobile first site using Gatsby and SASS

Community feedback

• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Vinci Taylaran,

  First of all, congrats for the challenge !

  I'd like to add a suggestion for the scroll bars. When you click on the "back project button" to open the pop-up, it adds a scroll bar which is quite heavy looking on the right in my opinion. So by toggling overflow: hidden on the body it should remove the unnecessary one.

  Overall, well done for the challenge and happy coding ! 😃

  1

  ---

  

  Vinci Taylaran•185

  @vincitaylaranPosted over 3 years ago

  @RayaneBengaoui Good catch! I didn't notice that until you pointed it out. Thanks!!

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey great work you got there. But there are littles issues?

  1. At point 480px, you could white spaces on the screen, that is cause by something that is overlapping its container and you could see that the elements at the point is not visible and unscrollable.
  2. To fix this, you could just remove the width property in your .card-module--card--3Pd5m class .3 Remove the outline of the buttons so that when it is clicked, there will be no box that appears

  ^^

  1

  ---

  

  Vinci Taylaran•185

  @vincitaylaranPosted over 3 years ago

  @pikamart Thanks! I think I fixed the problem you mentioned by updating the media query to hide and show certain components at 480px. You just saved me from being embarassed by potential employers haha!

  0

  

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  @vincitaylaran hahaha I think even with that issues, they will still see you as potential fellow, you are good and I visit your portfolio, dang ^^

  0