Mobile first responsive page using CSS grid

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you.

  HTML

  In order to fix the accessibility issues:

  • You need to replace <div class="container"> with the <main class="container"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to include at least h1 element so you should use one <h1> element in the <main> tag. You can replace your <p class="headline-text">Improve your frontend skills by buiding projects</p> element with the <h1 class="headline-text">Improve your frontend skills by buiding projects</h1> element.
  • The <img> tag should include alt ="" attribute. You can apply like this:

  <img src="./images/image-qr-code.png" class="qr-code-img" alt="qr-code"/>
  

  After committing the changes on GitHub and you need to deploy it as a live site. Finally, you should click generate a new report on this solution page to clear the warnings.

  CSS

  • In order to center texts, you'd better add text-align: center to the .container

  .container{
      text-align: center;
  }
  

  Hope I am helpful. :)

  Marked as helpful

  0

  ---

  

  chanchala-amar•160

  @chanchala-amarPosted over 1 year ago

  @ecemgo Thank you for your very helpful feedback, I appreciate it.

  After committing the changes on GitHub and you need to deploy it as a live site. - I have deployed it as a live site on GitHub Pages and have included the URL in my submission - is it not visible?

  Thanks again!

  1

  

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  @chanchala-amar happy to help :)

  I'm able to view your GitHub repository. I mean, in order to fix the accessibility issue report, you need to click the button called like "generate report" on this page. However, before that, you need to update your code on GitHub and deploy it as live site again. I tried to explain it if you don't know. If you know this process, ignore this comment.

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  chanchala-amar•160

  @chanchala-amarPosted over 1 year ago

  @0xAbdulKhalid Thank you for your very helpful feedback. I will incorporate the suggested changes, thanks again!

  0