mobile first, responsive, html, scss, js

Community feedback

• 

  Kacper•205

  @gacburPosted almost 4 years ago

  I'm not an expert, but just wanted to say that responsiveness is well done and overall it looks really good!

  1

  ---

  

  Michelle•415

  @michellerachoPosted almost 4 years ago

  @gacbur thank you!

  1
• 

  P

  tediko•6,680

  @tedikoPosted almost 4 years ago

  Hello, michelle! 👋

  Well done! Your solution looks good and responds quite well! What i would suggest is:

  • For your .error-input. Change the box-shadow to 1px and additionaly change .form__input border-color to be same as your error box-shadow. Now the border will be all red without the grey.
  • You align your whole content with flexbox, so when i resize window on desktop your whole content is stick to top. Add some margin and you'll be good!
  • I believe you forgot about hover states.

  This is my approach to this challenge. Like most people here, I also learn but maybe you will find something good for yourself.

  Good luck with that, have fun coding! 💪

  0

  ---

  

  Michelle•415

  @michellerachoPosted almost 4 years ago

  @tediko thank you! I thought there was a weird gray outline on the error state and completely forgot about that 1px gray border 😅

  I set the container to margin: auto 0; and I thought that had fix it because I didnt want to set a fixed height 🤔

  I did forget about the hover state but I fixed it hoping nobody would catch that 😅

  Thanks again!

  0