mobile first -project-tracking-intro-component(HTML, CSS/ SASS and JS)

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Benjo Quilario! 👋

  Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. I really like the initial animation you added. Here's my few tips:

  • Change the alt attributes for the .hero__img, as it doesn't add any extra context for screen reader users. Since your image is decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • I noticed that you are using a static / picture for a menu. Maybe you could try to create an animated element instead? If you want to give it a shot I've published an article link on how to create a basic animated hamburger menu button for beginners.

  Good luck with that, have fun coding! 💪

  2

  ---

  

  Benjo Quilario•1,810

  @benjoquilarioPosted over 3 years ago

  @tediko thanks you for the tips tediko 🔥🔥

  0