Mobile first development with Sass no Script

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, John Norman! 👋

  Congrats on finishing another challenge! Your solution responds well and looks good. You're very close to design, no need to be pixel perfect :) Here are few suggestions from me:

  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Since your logo/feature/avatar images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.
  • Change z-index for footer because now it isn't clickable since you set negative z-index on that container.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  P

  John Norman•880

  @norman02Posted over 3 years ago

  @tediko thanks for another piece of great advise!

  0