Mobile first design using responsive layout

Community feedback

• 

  Akshay Magrani•975

  @akshaymagraniPosted almost 5 years ago

  Great work, Cory! You managed to resolve the issue yourself. And thank you @GerbenDol, your advice was helpful. It prompted me to work out your suggestion in codepen.io and it worked. That should be helpful to me in the future.

  0

  ---

  

  Gerben Dol•3,115

  @GerbenDolPosted almost 5 years ago

  @akshaymagrani Cool to hear you learned something from it! 😁

  0
• 

  

  Matt Studdert•13,631

  @mattstuddertPosted almost 5 years ago

  That's great to hear you resolved your issue, Cory. One really good next step would be to try resolving the accessibility issues with the social icons.

  Great work on this challenge, keep it up! 👍

  0

  ---

  

  Cory R•100

  @CoryRunnPosted almost 5 years ago

  @mattstuddert Hm, I have my font awesome icons wrapped in span tags and nested inside the a tag. How can I make those a tags accessible but use an icon instead of text??? Can I add an alt somewhere?

  0

  

  Cory R•100

  @CoryRunnPosted almost 5 years ago

  @CoryRunn Never mind @mattstuddert, I believe I figured it out. alt was not the answer.

  0

  

  

  Matt Studdert•13,631

  @mattstuddertPosted almost 5 years ago

  @CoryRunn great to see you've sorted it, Cory. Nice work!

  0

  

  Cory R•100

  @CoryRunnPosted almost 5 years ago

  @mattstuddert Thank you! Love this site. I learned so much with every project.

  1

  

  

  Matt Studdert•13,631

  @mattstuddertPosted almost 5 years ago

  @CoryRunn that’s awesome to hear!

  0
• 

  Akshay Magrani•975

  @akshaymagraniPosted almost 5 years ago

  Hey Cory,

  Regarding making your media links clickable from the circle - You can nest the media within a button element, something like this -

  <button name="button" class="button"><"Your media icon"></button>

  Use CSS to make the button circular - width, height, and border-radius.

  Hope this helps.

  0

  ---

  

  Gerben Dol•3,115

  @GerbenDolPosted almost 5 years ago

  @akshaymagrani As these are links to other websites stick to using the anchor tags.

  Just use the <li>-items for the spacing and add the styles for making the circles to the <a>!

  0

  

  Cory R•100

  @CoryRunnPosted almost 5 years ago

  @GerbenDol Not quite sure what you mean. Should I align-items on those specific anchor tags and then also style those anchor tags?

  0