Mobile first design using flexbox

Community feedback

• 

  dewslyse•3,025

  @dewslysePosted about 3 years ago

  Hello 👋! Nice job on your submission.

  Some minor things to note:

  • Your could center the card to the page by adding the following the body

  body {
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
    flex-direction: column;
  }
  

  Or you could just change the html in your css to body

  • You could use more semantic html elements. At least wrapping your main content within the main tag would help resolve some of the accessibility issues raised in the report.
  • Wouldn't it be more appropriate to use an <a> instead of a <button> for Proceed to Payment ? Proceed somehow implies navigation

  Marked as helpful

  0

  ---

  

  ccbdp•315

  @ccbdpPosted about 3 years ago

  @dewslyse Thank you for your feedback! I would definitely apply the concepts you said when I edit this project and the projects I make moving forward!

  0