Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile first approach using SASS and JS

Dhawal 120

@dhawalRath

Desktop design screenshot for the Loopstudios landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please provide feedback it would be helpful to me.

Community feedback

P
tediko 6,680

@tediko

Posted

Hello, Dhawal! 👋 Well done on this challenge! Here's a few things I'd suggest you to take a look at:

  • Change your .hero height. For example to 500px. It can't be 100vh - which stands for 100 viewport height and is relative to 1% of the height of the viewport.
  • Remove background-color: #000; from your body or change it to white color so on bigger screen sizes there's no black background.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles. Keep up the good work! 💪
1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord