P
webdevbynight• 240
@webdevbynight
Posted
Some feedback:
- since all the images (except the logo) are cosmetic, you should try to serve them as background images in CSS (except for the gallery in the middle);
- the logo should be inserted into a
h1
element; - since the buttons are actually links, they should be tagged as
a
elements instead ofbutton
; - even though you use SCSS, you can now use custom properties to define variables in most cases;
- on the line 312 of your SCSS, when using
grid-template-*
, you should userepeat()
when two or more sibling rows or columns have the same size: in other words, you should declaregrid-template-columns: repeat(2, 1fr);
instead ofgrid-template-columns: 1fr 1fr;
; - you should avoid using pixels to define font sizes (here is a video explaining why);
- to display the circled numbers and the line above, you can generate pseudo-elements and use CSS counters (it is a bit challenging, but pleasant).
I hope this feedback helps you.
0