Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Media queries, margin

@augustofaggion

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What did you find difficult while building the project? To put on the center I think is still a problem for me, and the lines height between text

Which areas of your code are you unsure of?

I am not sure if i use the margin correctly, I know I achieve the project but i think i could do better in the feature

Do you have any questions about best practices? If you have any opinions how to make better feel free to help me

Community feedback

P
visualdennis 8,375

@visualdenniss

Posted

Hello Augusto,

nice job there. Few points to improve it even further:

  • Regarding centering, you don't need to use any margin, you can remove them as they are not required. All you need is min-height: 100vh; for the body to make it cover whole screen height, then use FLEXBOX or GRID, like display: grid; place-items: center;

  • Avoid fixed heights as it can cause various problems, instead let the content determine the size of container. Use paddings/margins inside if necessary.

  • Text color for the paragraph seems to be too bright, making it hard to read. Increase it to a darker value so it has enough contrast with the background for a better UX.

Hope you find this feedback helpful!

Marked as helpful

1

@augustofaggion

Posted

@visualdenniss Thank you it is very helpful :)

0
Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you.

HTML

  • In order to fix the accessibility issues, you need to replace <div class="white-container"> with the <main> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

  • Also, each main content needs to start with an h1 element, and also contain only one h1 element. Your accessibility report states the need for one main landmark. So, you need to use a <h1> element in the <main> tag instead of using <h2>. You can replace and combine your <h2>Improve your front-end</h2> & <h2>skills by building projects</h2> elements with the <h1>Improve your front-end skills by building projects</h1> element.

CSS

  • If you want to center it correctly, you can add these styles:
body {
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;  // instead of using  "height: auto;"
}

Hope I am helpful. :)

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord