@visualdenniss
Posted
Hello Augusto,
nice job there. Few points to improve it even further:
-
Regarding centering, you don't need to use any margin, you can remove them as they are not required. All you need is min-height: 100vh; for the body to make it cover whole screen height, then use FLEXBOX or GRID, like display: grid; place-items: center;
-
Avoid fixed heights as it can cause various problems, instead let the content determine the size of container. Use paddings/margins inside if necessary.
-
Text color for the paragraph seems to be too bright, making it hard to read. Increase it to a darker value so it has enough contrast with the background for a better UX.
Hope you find this feedback helpful!
Marked as helpful
@augustofaggion
Posted
@visualdenniss Thank you it is very helpful :)